fix(cli): remove shell:true from spawn in generate command#2270
Merged
fahreddinozcan merged 2 commits intoupstash:masterfrom Mar 19, 2026
Merged
fix(cli): remove shell:true from spawn in generate command#2270fahreddinozcan merged 2 commits intoupstash:masterfrom
fahreddinozcan merged 2 commits intoupstash:masterfrom
Conversation
Removes shell:true from the child_process.spawn() call that opens the user's editor. The editor path and preview file path are already passed as separate arguments, so shell interpolation is unnecessary. Using shell:true allows shell metacharacters in EDITOR or file paths to be interpreted, which is a command injection vector. Fixes upstash#2240 This contribution was developed with AI assistance (Claude Code). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fahreddinozcan
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shell: truefrom thechild_process.spawn()call in thegeneratecommand's "open in editor" flowspawn(), so shell interpolation is not neededshell: true, a malicious$EDITORvalue or a crafted file path containing shell metacharacters could execute arbitrary commandsDetails
In
packages/cli/src/commands/generate.tsline 440, the spawn call usesshell: trueunnecessarily. Node'sspawnwithoutshell: trueexecutes the binary directly viaexecvp, which safely handles arguments without shell interpretation.This is a one-line removal. No behavior change for normal editor values like
vim,nano,code, oropen.Fixes #2240
This contribution was developed with AI assistance (Claude Code).