chore: scoped public span params + CountLeadingZeros test/benchmark cleanup#6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small, dependency-free cleanups to the Base58 library:
Defensive
scopedon public span parameters — annotate the publicEncode/DecodeReadOnlySpan/Spanparameters withscoped(mirrors MessagePack-CSharp #2271). Documents and compiler-enforces that the API never captures caller buffers. No codegen change, non-breaking.CountLeadingZeros test + benchmark cleanup — retarget the leading-zero tests from now-deleted internals to the public
CountLeadingZeroscontract (plus an all-zeros case and deterministic inputs), and add anIndexOfAnyExceptvariant toCountLeadingZerosBenchmarkthat records the measured result: the BCL span-scan is ~27% slower than the hand-rolled SIMD path, so it was measured and not adopted.Parked for later
A separate SIMD / table-layout exploration (flattening the
uint[][]lookup tables,TensorPrimitives.Dot) is kept on a localexperiment/base58-simd-tablesbranch.TensorPrimitives.Dot<ulong>showed a real decode kernel win but requires an ML-math (System.Numerics.Tensors) dependency, and firedancer itself keeps the matrix-multiply scalar — so it needs more end-to-end evaluation before adopting. Not part of this PR.Testing