7.2: Fix parsing ip addr with peer information#2544
Open
ap-wtioit wants to merge 1 commit intounraid:7.2from
Open
7.2: Fix parsing ip addr with peer information#2544ap-wtioit wants to merge 1 commit intounraid:7.2from
ap-wtioit wants to merge 1 commit intounraid:7.2from
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding tun0 to listening interfaces in settings. Unraid 7+ tries to parse:
ip addr show scope global primary -deprecated dev tun0and gets
10.9.8.66 peer 10.9.8.65/32 scope global tun0as the "IP" of the interface. This then proceeds to break sshd and nginx config for unraid.With this fix the peer information is removed and only the interfaces IP (in the example 10.9.8.66) is kept.
Info @wt-io-it