Skip to content

CI: make the Storybook deploy check verify the preview is actually live #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivoIturrieta wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CI: make the Storybook deploy check verify the preview is actually live #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/deploy-storybook.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@ jobs:
- name: Build Storybook
run: pnpm --filter @unlayer/react-elements run build-storybook

# Stamp the artifact so the verify step can prove THIS build is the
# one being served — not a stale previous deploy.
- name: Stamp build id
run: echo "${{ github.run_id }}" > packages/react/storybook-static/build-id.txt

# Get the GitHub Pages URL dynamically
- name: Get Pages URL
id: pages
Expand Down Expand Up @@ -87,6 +92,29 @@ jobs:
if: github.event_name == 'pull_request'
run: echo "::notice::Storybook preview deployed to ${{ steps.pages.outputs.url }}pr/${{ github.event.pull_request.number }}/"

# The green check must mean "this exact build is being served" — the
# push to gh-pages can succeed while GitHub's own Pages publish fails
# transiently (and it does not auto-retry), silently serving a stale
# preview. Poll the deployed build stamp until it matches this run.
- name: Verify deployment is live
run: |
if [ "${{ github.event_name }}" = "pull_request" ]; then
TARGET="${{ steps.pages.outputs.url }}pr/${{ github.event.pull_request.number }}/build-id.txt"
else
TARGET="${{ steps.pages.outputs.url }}build-id.txt"
fi
echo "Verifying $TARGET serves build ${{ github.run_id }}"
for i in $(seq 1 40); do
LIVE=$(curl -fs -H 'Cache-Control: no-cache' "$TARGET?cb=${{ github.run_id }}-$i" || true)
if [ "$LIVE" = "${{ github.run_id }}" ]; then
echo "Live after ~$((i * 15))s"
exit 0
fi
sleep 15
done
echo "::error::Pages never served this build (currently serving: '${LIVE:-nothing}'). GitHub's Pages publish likely failed — re-run this workflow, or trigger a rebuild with: gh api -X POST repos/${{ github.repository }}/pages/builds"
exit 1

- name: Add Storybook link to PR description
if: github.event_name == 'pull_request'
uses: actions/github-script@v7
Expand Down
Loading