Skip to content

build: Complete Spring Boot 3 migration: update dependencies, fix deprecated APIs, and add packaging workflow#235

Merged
unknowIfGuestInDream merged 3 commits intomasterfrom
copilot/upgrade-springboot3
Feb 28, 2026
Merged

build: Complete Spring Boot 3 migration: update dependencies, fix deprecated APIs, and add packaging workflow#235
unknowIfGuestInDream merged 3 commits intomasterfrom
copilot/upgrade-springboot3

Conversation

Copy link
Contributor

Copilot AI commented Feb 28, 2026

Finishes the Spring Boot 3 migration by addressing remaining dependency and API issues, and adds a manual packaging workflow.

Proposed Changes

  1. Remove log4j2.version override — The pinned 2.17.0 (a Log4Shell-era workaround) was downgrading from SB3's managed 2.23.1. Removed to use the managed version.
  2. Update MySQL connectormysql:mysql-connector-java:5.1.49com.mysql:mysql-connector-j (SB3-managed 8.3.0). Old coordinates and 5.1.x are deprecated.
  3. Update git-commit-id pluginpl.project13.maven:git-commit-id-pluginio.github.git-commit-id:git-commit-id-maven-plugin. Old groupId is deprecated; SB3 uses the new coordinates.
  4. Replace deprecated ListenableFuture in VisibleThreadPoolTaskExecutorsubmitListenable()submitCompletable(), removed deprecated execute(Runnable, long) override. These were deprecated in Spring Framework 6.
  5. Add manual packaging workflow — New .github/workflows/package.yml triggered only via workflow_dispatch. Builds with mvn package, uploads genCode.jar as an artifact with 1-day retention.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as either enhancement, bug, documentation, style or dependencies
  • Verify design and implementation
Original prompt

This section details on the original issue you should resolve

<issue_title>[Feature Request] 项目升级打牌SpringBoot3</issue_title>
<issue_description>### Checklist

  • I searched exising issues and no one else requests similar feature.
  • I think that 25%+ users are positive towards this feature.

Describe the feature

当前项目要升级到SpringBoot3, jdk 还是用17
版本号为5.0
请帮我完成升级
各个依赖也需要升级,保证功能完整迁移
代码能在升级后正常运行
配置项也需要更新

Additional context

No response</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@naming-conventions-bot
Copy link

Thank you for following naming conventions! 😻

@mergify
Copy link

mergify bot commented Feb 28, 2026

Thanks for opening this pull request!
Please check out the Contributing Guidelines.

@mergify
Copy link

mergify bot commented Feb 28, 2026

@Copilot
Wrong PR Title: [WIP] Upgrade project to Spring Boot 3 and JDK 17
Please check Contributing Guidelines for more information.

…ted APIs

- Remove log4j2.version override (2.17.0→SB3-managed 2.23.1)
- Update MySQL connector (mysql:mysql-connector-java:5.1.49→com.mysql:mysql-connector-j:8.3.0)
- Update git-commit-id plugin (pl.project13.maven→io.github.git-commit-id)
- Replace deprecated ListenableFuture with CompletableFuture in VisibleThreadPoolTaskExecutor

Co-authored-by: unknowIfGuestInDream <57802425+unknowIfGuestInDream@users.noreply.github.com>
@what-the-diff
Copy link

what-the-diff bot commented Feb 28, 2026

PR Summary

  • New GitHub Actions Workflow for Project Packaging
    The team has integrated a new automated process for compiling and preparing the project for distribution. This updated process uses the latest Java Development Kit (JDK 17) and Maven, a project management tool, to build the project while skipping tests for efficient packaging.

  • Update in Database Connector and General Dependency Updates
    The outdated MySQL database connector in the project setup file (pom.xml) has been replaced with a more current version (mysql-connector-j). Additionally, a dependency associated with documenting Git commits within the project has been modernized.

  • Code Refactoring and Modernization
    The module VisibleThreadPoolTaskExecutor.java has undergone improvements and clean-ups. A deprecated method has been removed to avoid potential issues in the future owing to lack of support. The functionality to send multiple asynchronous tasks (submitListenable methods) now returns CompletableFuture, a feature of Java's API that allows for more flexible and powerful handling of tasks running concurrently. This improves the performance and reliability of the application.

Copilot AI changed the title [WIP] Upgrade project to Spring Boot 3 and JDK 17 Complete Spring Boot 3 migration: update dependencies and fix deprecated APIs Feb 28, 2026
@unknowIfGuestInDream unknowIfGuestInDream marked this pull request as ready for review February 28, 2026 05:45
@github-actions github-actions bot added enhancement New feature or request dependencies Pull requests that update a dependency file labels Feb 28, 2026
@unknowIfGuestInDream unknowIfGuestInDream changed the title Complete Spring Boot 3 migration: update dependencies and fix deprecated APIs build: Complete Spring Boot 3 migration: update dependencies and fix deprecated APIs Feb 28, 2026
@unknowIfGuestInDream
Copy link
Owner

@copilot mysql-connector-j 和 git-commit-id-maven-plugin 没定义版本号,怎么编译过?

Copy link
Contributor Author

Copilot AI commented Feb 28, 2026

@copilot mysql-connector-j 和 git-commit-id-maven-plugin 没定义版本号,怎么编译过?

这两个的版本由 spring-boot-starter-parent:3.3.5 的 dependency management 和 plugin management 统一管理,不需要显式定义版本号。实际解析的版本为:

  • com.mysql:mysql-connector-j8.3.0
  • io.github.git-commit-id:git-commit-id-maven-plugin8.0.2

这也是 Spring Boot 推荐的用法——对于其管理范围内的依赖和插件,省略版本号可以确保与 Spring Boot 版本的兼容性。

@unknowIfGuestInDream
Copy link
Owner

@copilot 加一个只能手动执行的工作流文件,用于执行打包工作,打包产物保留1天

Co-authored-by: unknowIfGuestInDream <57802425+unknowIfGuestInDream@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 28, 2026

@copilot 加一个只能手动执行的工作流文件,用于执行打包工作,打包产物保留1天

已在 d4346c8 添加 .github/workflows/package.yml,仅支持 workflow_dispatch 手动触发,使用 mvn package 打包后通过 actions/upload-artifact@v4 上传 genCode.jarretention-days: 1

Copilot AI changed the title build: Complete Spring Boot 3 migration: update dependencies and fix deprecated APIs build: Complete Spring Boot 3 migration: update dependencies, fix deprecated APIs, and add packaging workflow Feb 28, 2026
@sonarqubecloud
Copy link

@unknowIfGuestInDream unknowIfGuestInDream merged commit 1836657 into master Feb 28, 2026
48 checks passed
@unknowIfGuestInDream unknowIfGuestInDream deleted the copilot/upgrade-springboot3 branch February 28, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request size/M workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] 项目升级打牌SpringBoot3

2 participants