Move the test app and the addon to ember-source 7.2 - #195
Open
NullVoxPopuli-ai-agent wants to merge 1 commit into
Open
Move the test app and the addon to ember-source 7.2#195NullVoxPopuli-ai-agent wants to merge 1 commit into
NullVoxPopuli-ai-agent wants to merge 1 commit into
Conversation
The try scenarios test ember-release, ember-beta and ember-canary, all of which are ember 7 now, while the default scenario ran 6.11. The default now matches. - test-app: ember-source and ember-cli to ~7.2.0 - test-app: @embroider/core 4.6.3, @embroider/vite 1.7.9, @embroider/compat 4.1.22 - table: the ember-source devDependency to ^7.2.0, so types are checked against 7 The peerDependency range is unchanged, and the addon still supports 3.28 up. pnpm re-resolves a whole importer when its manifest changes, because .npmrc sets resolution-mode=highest. That is why the lockfile diff is large, and why test-app now injects the addon (file:) instead of linking it. The CI action downloads the built package before it installs, so the injected copy has dist and declarations. docs-app stays on 6.11. It needs ember-concurrency 5, which arrives with ember-mobile-menu 6.1, and re-resolving docs-app also moves @universal-ember/docs-support to 0.9.13, which dropped the `/tailwind` export that config/tailwind.config.mjs imports. That is separate work. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI tests ember-release, ember-beta and ember-canary, which are all ember 7 now, while the default scenario ran 6.11. The default matches the release channel again.
Changes
test-app:ember-sourceandember-clito~7.2.0test-app:@embroider/core4.6.3,@embroider/vite1.7.9,@embroider/compat4.1.22table: theember-sourcedevDependency to^7.2.0, so types are checked against 7The
ember-sourcepeerDependency range is untouched. The addon still supports 3.28 and up.Two things to know about the lockfile
.npmrcsetsresolution-mode=highest, so pnpm re-resolves an entire importer when its manifest changes. That is why the diff is large although only 6 packages actually change version.The same re-resolution makes
test-appinject the addon (file:table) rather than link it, which is whatinject-workspace-packages=trueasks for. Thedownload-built-packageaction downloads the artifact intotable/before it runspnpm install --force, so the injected copy hasdistanddeclarations.docs-app is not included
It stays on 6.11. Ember 7 removed the
emberbarrel module, andember-concurrency4 imports it:ember-concurrency5.2 dropped that import, and it arrives withember-mobile-menu6.1. But re-resolvingdocs-appalso moves@universal-ember/docs-supportfrom 0.9.2 to 0.9.13, which no longer ships the/tailwindexport thatdocs-app/config/tailwind.config.mjsimports. That is its own piece of work.Verification
pnpm turbo --filter test-app test: 187 pass, 0 fail on ember-source 7.2.0pnpm turbo lint: 4 packages passvite buildindocs-appstill succeeds, unchanged on 6.11Please label this
internal.🤖 Generated with Claude Code