Skip to content

Fix ember-release, ember-beta and ember-canary on ember-source 7 - #194

Merged
NullVoxPopuli merged 1 commit into
universal-ember:mainfrom
NullVoxPopuli-ai-agent:fix-ember-7-template-compiler
Aug 19, 2026
Merged

Fix ember-release, ember-beta and ember-canary on ember-source 7#194
NullVoxPopuli merged 1 commit into
universal-ember:mainfrom
NullVoxPopuli-ai-agent:fix-ember-7-template-compiler

Conversation

@NullVoxPopuli-ai-agent

Copy link
Copy Markdown

The three try scenarios have been failing on every branch, not just recent ones. They now pass.

Cause

babel.config.cjs in test-app and docs-app sets:

compilerPath: 'ember-source/dist/ember-template-compiler.js',

ember-source 7.0 removed that file and its explicit exports entry. What is left is the wildcard "./*": "./dist/{prod,dev}/packages/*", so the old specifier resolves to dist/prod/packages/dist/ember-template-compiler.js, which does not exist. The vite build fails before a single test runs:

[commonjs--resolver] [BABEL] .../ember-source/dist/dev/packages/ember-testing/index.js:
Cannot find module '.../ember-source/dist/prod/packages/dist/ember-template-compiler.js'
imported from .../babel-plugin-ember-template-compilation/dist/src/node-main.js

Fix

compilerPath: 'ember-source/ember-template-compiler/index.js',

That specifier resolves on both layouts:

  • 6.11: ./* maps to dist/packages/*
  • 7.x: ./* maps to dist/prod/packages/* and dist/dev/packages/*

The module exports precompile, _preprocess and _buildCompileOptions, which is what babel-plugin-ember-template-compilation reads. It also ends the "legacy ember-template-compiler.js AMD bundle" deprecation that lint prints today.

Verification

Ran locally with ember try:one:

Scenario ember-source Result
ember-release 7.2.0 187 pass, 0 fail
ember-beta 7.3.0-beta.1 187 pass, 0 fail
ember-canary 7.4.0-alpha.1 187 pass, 0 fail

The default scenario on 6.11.0 still passes 187, and vite build in docs-app succeeds.

Please label this internal.

🤖 Generated with Claude Code

ember-source 7.0 removed `dist/ember-template-compiler.js` and the exports
entry for it. Its wildcard export maps `./*` to `dist/{prod,dev}/packages/*`,
so the old path resolved to `dist/prod/packages/dist/ember-template-compiler.js`
and the build died with "Cannot find module" before a single test ran.

`ember-source/ember-template-compiler/index.js` resolves on both layouts, and
exports the `precompile`, `_preprocess`, and `_buildCompileOptions` that
babel-plugin-ember-template-compilation looks for.

Ran locally with `ember try:one`: ember-release (7.2.0), ember-beta (7.3.0-beta.1)
and ember-canary (7.4.0-alpha.1) each pass 187 tests. Default (6.11.0) still
passes, and the docs app still builds.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@NullVoxPopuli
NullVoxPopuli merged commit 2cd31cb into universal-ember:main Aug 19, 2026
13 checks passed
@github-actions github-actions Bot mentioned this pull request Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants