Codefences update - #384
Merged
Merged
Conversation
|
|
NullVoxPopuli
marked this pull request as ready for review
August 19, 2026 16:14
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
gitKrystan
added a commit
to gitKrystan/kolay
that referenced
this pull request
Aug 19, 2026
main gained frontmatter support (universal-ember#384 and friends) while this branch was in review, and the two overlapped in `setup.js`: both changed it to read every markdown page's source. Resolved to keep both intents, with one correction — headings are now taken from the frontmatter-stripped `content` rather than the raw source, because a YAML comment line starts with `#` and would otherwise be read as a page's first heading. Frontmatter does not title a page: `defaultPopulateManifestEntry` nests it under `meta`, so `title:` in frontmatter is `meta.title` and the page still falls back to its heading or filename. Verified rather than assumed, and documented, since it is the obvious thing to expect. The three conflicts were `setup.js`, `parse.js` (imports), and markdown-only's application test, where both sides appended a module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.