docs-app: preview the unreleased kolay (docs() + apiDocs() plugin split) - #794
Merged
NullVoxPopuli merged 4 commits intoJul 27, 2026
Merged
Conversation
|
|
Contributor
|
kolay's next release reworks the plugin API (universal-ember/kolay#323): the combined kolay() vite plugin is split into docs() + apiDocs(), and page json configs use "title" instead of "componentName". To preview those changes before the release, resolve kolay to the built package contents that kolay pushes to its dist branch on every commit to main (a pnpm override, so the docs-app and docs-support keep their semver ranges). When kolay releases, the override goes away and the ranges get bumped instead. - vite.config: docs({ ... }) serves the co-located app/templates pages; apiDocs([...]) takes over the packages list - addRoutes(this) and setupKolay() are unchanged for this setup - otp/otp-input page configs: componentName -> title (side-nav already falls back to title) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
NullVoxPopuli-ai-agent
force-pushed
the
docs-kolay-preview
branch
from
July 27, 2026 13:52
819eaaf to
8f9e924
Compare
NullVoxPopuli
pushed a commit
to universal-ember/kolay
that referenced
this pull request
Jul 27, 2026
A <details> under Install explains that every push to main publishes the built package contents to the dist branch (push-dist.yml), so the unreleased kolay can be tried with pnpm add kolay@github:universal-ember/kolay#dist — or a pnpm override when a workspace has multiple kolay consumers (this is how ember-primitives previews the plugin rework, universal-ember/ember-primitives#794). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
kolay's typedoc renderer writes names (@arg, <:block>) as <pre class="typedoc__name">, so the prose code-block treatment (dark slab background, shadow, block padding) swallowed the reworked types-read-like-code rendering. Exclude them inside the existing :where() guards (specificity stays zero). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The deploy preview rendered every typedoc token in the prose body color while dev builds showed the palette. Vite 8's default cssTarget predates light-dark(), so lightningcss rewrote kolay's colors into var(--lightningcss-light/dark) space toggles whose :root definitions don't survive chunking — both fallbacks resolve, the declaration is invalid at computed-value time, and the color inherits. The rewrite would also key theming off prefers-color-scheme instead of our color-scheme toggle. Target browsers that support light-dark() natively so it ships as authored. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
NullVoxPopuli
approved these changes
Jul 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kolay's next release reworks the vite plugin API (universal-ember/kolay#323; the changes are on kolay's
mainbut unreleased). This PR lets us preview those changes on the ember-primitives docs before the release.How the preview works
kolay pushes its built package contents to its
distbranch on every commit tomain(viapush-dist.yml). A rootpnpm.overridesentry resolveskolaytogithub:universal-ember/kolay#distfor the whole workspace, sodocs-appand@universal-ember/docs-supportkeep their declared semver ranges. When kolay releases, we drop the override and bump the ranges instead.Migration changes
kolay()plugin is split —docs({ rehypePlugins, scope })(no group: serves the co-locatedapp/templatespages) +apiDocs(["ember-primitives", "which-heading-do-i-need"]).componentName→titlefor the OTP/OTPInput pages.docs-support'sside-navalready falls back totitle, and the rendered nav text is identical; thecomponentNamebranch is kept so docs-support still works with kolay 5.x.addRoutes(this)still serves co-located pages from the root URL space (URLs stay the same), andsetupKolay()'stopLevelScope/modulesoptions are untouched.Verification
docs-appvite build --mode development+ testem suite passes locally (the pages test walks every docs page in all three color schemes)lint:typespasses indocs-appandpackages/docs-support🤖 Generated with Claude Code