Repository navigation
fix: support Tailwind import options in theme generation #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5d17a05
fix: support Tailwind import options in theme generation
Brentlok 0822a49
test: cover multiple variants in imported themes
Brentlok 98c93f8
fix: strip quoted Tailwind import option paths
Brentlok 2c77152
fix: preserve comments when stripping Tailwind import options
Brentlok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
packages/uniwind/tests/web/bundler/themes-import-options.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| import fs from 'fs' | ||
| import path from 'path' | ||
| import { afterEach, beforeEach, describe, expect, test } from 'vitest' | ||
| import { generateCSSForThemes } from '../../../src/bundler/artifacts/css/themes' | ||
|
|
||
| describe('Tailwind import options', () => { | ||
| let dir: string | ||
|
|
||
| beforeEach(() => { | ||
| dir = fs.mkdtempSync(path.join(__dirname, '.tmp-themes-')) | ||
| }) | ||
|
|
||
| afterEach(() => { | ||
| fs.rmSync(dir, { recursive: true, force: true }) | ||
| }) | ||
|
|
||
| const generate = async (globalCSS: Array<string>, themeFile = 'theme.css') => { | ||
| fs.writeFileSync( | ||
| path.join(dir, themeFile), | ||
| [ | ||
| '@variant light { --color-background: white; }', | ||
| '@variant dark { --color-background: black; }', | ||
| ].join('\n'), | ||
| ) | ||
| fs.writeFileSync(path.join(dir, 'global.css'), globalCSS.join('\n')) | ||
|
|
||
| return generateCSSForThemes(['light', 'dark'], path.join(dir, 'global.css')) | ||
| } | ||
|
|
||
| test.each([ | ||
| `source('./')`, | ||
| `source("./src/(app)")`, | ||
| `source('./src/(app);')`, | ||
| 'source(none)', | ||
| 'prefix(tw)', | ||
| 'theme(static)', | ||
| ])('@import with %s still collects theme variables', async option => { | ||
| const css = await generate([ | ||
| `@import 'tailwindcss' ${option};`, | ||
| `@import './theme.css' ${option};`, | ||
| ]) | ||
|
|
||
| expect(css).toContain('--color-background: unset;') | ||
| }) | ||
|
|
||
| test('quotes inside comments do not break option stripping', async () => { | ||
| const css = await generate([ | ||
| `@import 'tailwindcss' /* don't */ source('./');`, | ||
| `@import './theme.css';`, | ||
| ]) | ||
|
|
||
| expect(css).toContain('--color-background: unset;') | ||
| }) | ||
|
|
||
| test('option-like text inside the import path is kept', async () => { | ||
| const css = await generate([ | ||
| `@import 'tailwindcss' source('./');`, | ||
| `@import './theme source(none).css';`, | ||
| ], 'theme source(none).css') | ||
|
|
||
| expect(css).toContain('--color-background: unset;') | ||
| }) | ||
| }) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.