adds css tooltips section in interactions#61
Open
josephjguerra wants to merge 1 commit intouna:gh-pagesfrom
josephjguerra:gh-pages
Open
adds css tooltips section in interactions#61josephjguerra wants to merge 1 commit intouna:gh-pagesfrom josephjguerra:gh-pages
josephjguerra wants to merge 1 commit intouna:gh-pagesfrom
josephjguerra:gh-pages
Conversation
Owner
|
Thanks for this PR, left a few comments! |
Author
|
Where are the comments @una ? I don't see them. |
una
reviewed
Nov 17, 2016
| } | ||
|
|
||
| .tooltip:hover::before, | ||
| .tooltip:focus::before, |
Owner
There was a problem hiding this comment.
Do you mind rewriting this in Sass to make it more concise for the demo?
| @@ -0,0 +1,5 @@ | |||
| <p>You can use good old HTML and CSS to make tooltips, instead of jQuery or JavaScript.</p> | |||
Owner
There was a problem hiding this comment.
this html file is typically reserved for just the HTML code in the example
Owner
|
@josephjguerra sorry I forgot to hit "submit" with the new GH code review system |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fun with css tooltips!
The default gulp build looks like it added aria-labels and rebuilt the lightbox section.