TECH-155: resolve issues raised by copilot

[ACM02]

Jira Issue Reference

• Jira Issue: TECH-155

Type of Change

• Bug Fix
• Feature
• Update / Improvement
• Documentation only
• Other:

Description

Fixed issues raised by Copilot in this release PR: #137

Render button as child (src/app/events/goosies-2024/page.tsx)

This renders an (from Link) inside a (from Button), which is invalid HTML and can cause accessibility/interaction issues. Prefer Button with asChild so it renders the Link as the interactive element (or remove the Link entirely if it’s just a disabled/closed state).
#137 (comment)

Added the asChild prop as suggested

Numeric prop for height/width

next/image expects a numeric type for height/width, so this was fixed in all occurrences across the codebase.

#137 (comment)

Change link wording (src/data/events.ts)

Changed the wording of the link for the 2024 goosies page from View photos to See page since it isn't a photo gallery. This is consistent with other event pages.

#137 (comment)

Fix double fetching (src/components/page-header.tsx)

The page header file was double fetching the header on every load, once with the mobile size and once with the desktop size. By marking them as hidden it now only fetches once.

TODO: This is now fetching different image sizes than before which seems less optimized, need to resolve this before marking this as ready to review

Before:

After:

#137 (comment)

Testing

Ensure you've tested the following, if applicable. Select all that apply.

• Mobile/Desktop View
• Accessibility
• Functionality
• Edge cases
• Not tested
• Other testing:

---

Note: Ensure you put [skip ci] in the commit message AND code review title if these are changes that shouldn’t run the CI, such as documentation changes