chore(release): set version to 0.6.0 and unpin FileVersion - #89
Merged
Conversation
AssemblyVersion and FileVersion were hardcoded to 0.3.4.0 while CI only overrides Version (via -p:Version= from the git tag). The two never met, so every release up to and including v0.5.0 shipped binaries whose Windows file-properties dialog read "File version 0.3.4.0" against "Product version 0.5.0". Removed both pinned elements so they derive from Version, and set Version to 0.6.0 for local build clarity. CI still overrides it from the tag. Verified with a CI-shaped publish (-p:Version=0.6.0): FileVersion : 0.6.0.0 (was 0.3.4.0) ProductVersion : 0.6.0+a13bca5 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NDsEfog5kVkT5NmX1Ya5be
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last piece of the v0.6.0 pre-release review — finding 04.
Problem
AssemblyVersionandFileVersionwere hardcoded to0.3.4.0in the csproj, while CI only overridesVersion(via-p:Version=from the git tag). Those never meet, so the pinned values won.Result: every release up to and including v0.5.0 shipped binaries where Windows' file-properties dialog reads File version 0.3.4.0 against Product version 0.5.0. Anyone checking the version the normal Windows way — right-click → Properties → Details — got a wrong answer. Confirmed against the installed v0.5.0 build.
Fix
Removed both pinned elements so they derive from
Version, and setVersionto0.6.0for local build clarity. CI still overrides it from the tag, so this stays correct for future releases instead of drifting again.Verification
CI-shaped publish (
-p:Version=0.6.0) against this branch:No external consumers bind against this assembly, so the
AssemblyVersionchange is inert.🤖 Generated with Claude Code
https://claude.ai/code/session_01NDsEfog5kVkT5NmX1Ya5be