fix(chocolatey): serve the icon from a CDN and check for WebView2 - #112
Merged
Conversation
Moderator feedback on the 0.5.0 submission. Install side was passed as clean (official GitHub MSI with SHA256, silent /qn, proper uninstall, clean scan); one required change and one suggestion. Required: iconUrl was a raw.githubusercontent.com link, which Chocolatey does not permit. Switched to the jsdelivr CDN URL the moderator supplied, still pinned to commit ad0ea18 rather than a branch so the icon cannot change underneath a published package. Verified the CDN serves it: 200, image/png, 2530 bytes — byte-identical to src/CodeShellManager/Assets/app.png. Suggested: the description mentions WebView2 but nothing checked for it. Added a registry probe for the Evergreen Runtime that WARNS rather than fails. It ships with Windows 11 and recent Windows 10, so a detection miss must not block an install that would have worked — but a genuinely missing runtime means blank terminals, which is worth naming at install time rather than leaving the user to discover. Deliberately a check and not a <dependency> on webview2-runtime: a dependency would pull and install the runtime on every machine, including the majority that already have it. Probes WOW6432Node first, which is where it actually resolved when tested (152.0.4191.53); HKLM and HKCU are fallbacks. Both files verified to parse. Note this needs resubmitting as 0.5.0 per the moderator, and the CHOCO_API_KEY 403 from the v0.6.0 attempt is still unresolved — that has to be sorted before any push succeeds. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NDsEfog5kVkT5NmX1Ya5be
AThraen
added a commit
that referenced
this pull request
Sep 8, 2026
…asked for (#130) The v0.5.0 submission — the package's first — was approved on 08 Sep 2026 after sitting in human review since May. CLAUDE.md told the next reader not to dispatch chocolatey.yml, which is now wrong and would have skipped the mirror. Recorded instead of just deleted, because two things from that first submission are worth keeping: - A first submission to a NEW package id goes to human review and can take months. Only the first; later versions from a maintainer with an approved package auto-verify. That is a release-planning fact, not trivia. - Don't back-fill 0.6.0/0.7.0. Only the newest version matters to `choco install`, so go straight to the current tag. Also explains the download counter: 44 for a package that spent its whole life unlisted and un-installable without an explicit --version. The moderator endorsed the #112 WebView2 approach — probe all three EdgeUpdate keys and warn with a symptom and remedy rather than hard-fail or force-install. They raised `<dependency id="webview2-runtime" />` and then argued against it themselves, since it forces an install on machines that already have the runtime (all of Windows 11). Recorded as a decision so it isn't relitigated. nuspec: adds the MIT licence line they suggested. licenseUrl already pointed at the repo LICENSE; the description didn't say so. Claude-Session: https://claude.ai/code/session_01NDsEfog5kVkT5NmX1Ya5be Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moderator feedback on the 0.5.0 submission. The install side was passed as clean — official GitHub MSI with a SHA256, silent
/qn, proper uninstall, clean scan. One required change, one suggestion.Required — iconUrl must be a CDN
raw.githubusercontent.comisn't permitted. Switched to the jsdelivr URL the moderator supplied, still pinned to commitad0ea186rather than a branch, so the icon can't change underneath a published package.Verified rather than assumed:
Suggested — a WebView2 dependency or check
The description mentioned WebView2 but nothing checked for it. Added a registry probe for the Evergreen Runtime that warns rather than fails.
The reasoning: WebView2 ships with Windows 11 and recent Windows 10, so a detection miss must not block an install that would have worked. But a genuinely missing runtime means blank terminals, which is worth naming at install time rather than leaving the user to discover it.
Deliberately a check, not a
<dependency>onwebview2-runtime— a dependency would pull and install the runtime on every machine, including the majority that already have it.Probes
WOW6432Nodefirst, which is where it actually resolved when tested on a real machine (152.0.4191.53);HKLMandHKCUare fallbacks.Verified
chocolateyinstall.ps1parses (PowerShell AST parser)codeshellmanager.nuspecis well-formed XMLTwo things this does not solve
__VERSION__, so dispatchingchocolatey.ymlwithtag=v0.5.0rebuilds that package with the corrected nuspec.CHOCO_API_KEYstill returns 403. That failed on the v0.6.0 attempt on 19 Aug and was never resolved, so any push will fail regardless of this fix. Worth checking the key at https://community.chocolatey.org/account before dispatching.🤖 Generated with Claude Code
https://claude.ai/code/session_01NDsEfog5kVkT5NmX1Ya5be