Added support for for native OAuth login (#767) - #768
professorwaltwood wants to merge 24 commits into
Conversation
| ApplicationType::Native, | ||
| // We are going to use the Authorization Code flow. | ||
| vec![OAuthGrantType::AuthorizationCode { | ||
| redirect_uris: vec![ipv4_localhost_uri, ipv6_localhost_uri], |
There was a problem hiding this comment.
Shouldn't this be the redirect_uri returned by LocalserverBuilder::build() to include the port?
There was a problem hiding this comment.
iirc, oauth clients aren't restricted based off ports just scheme, host and path. Otherwise, for native clients like this, the client would need to re-register every time it needs to re-auth. This would also only work for dynamic client registration (should probably include an option in this PR for pre-registered iamb client)
|
not sure if it's limited to the oauth login method but when logging out, the crypto store isn't removed so on re-login, the client throws an error like this: |
3b968fc to
abd1c8f
Compare
abd1c8f to
e0d529c
Compare
|
Another thing I noticed is that I can login with a different user id than I set in the config. We should set |
4288a32 to
e220c26
Compare
VAWVAW
left a comment
There was a problem hiding this comment.
Is there still something blocking this on your side? Otherwise I would like to merge this.
PR for #767
First time contributing to iamb. Any issues or there's something I'm missing, please let me know