Only show joined and joinable rooms in spaces - #766
Merged
Merged
Conversation
ulyssa
added
the
ui
ulyssa
enabled auto-merge (squash)
October 4, 2026 19:08
Owner
Hiding them until information loads and then they appear is probably the right decision. There are some Matrix rooms and spaces in weird states out there, so waiting until we actually know it's something the user can interact with is probably the right call. |
Collaborator
Author
|
Yes, with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including private rooms in the space view can be annoying since they are only displayed as an room id and the user can't interact with them.
I'm not sure whether to hide or show rooms for which the preview is still loading. This will either lead to rooms appearing or disappearing from the list.