Enhanced parameter and output. #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojas-uls-dev
approved these changes
Jan 28, 2026
ojas-uls-dev
left a comment
ojas-uls-dev
left a comment
There was a problem hiding this comment.
Looks good. Slight nitpick added as comment though, but it should be inconsequential.
| def copy_xslx_to_batch(batch_path): | ||
| print(f"Copying spreadsheet to {batch_path}/manifest.xlsx") | ||
| shutil.copyfile(args.xls_file, batch_path+"/manifest.xlsx") | ||
| if os.path.isfile(batch_path+"/manifest.xlsx"): |
There was a problem hiding this comment.
batch_path+/manifest.xslx can fail on windows (which may or may not be a concern). Standard way to create paths is either by using os.path.join or Path(batch_path) / "manifest.xslx" where Path is imported as from pathlib import Path
There was a problem hiding this comment.
Also, while 99.999% of the time this check will work as intended, if the file is removed (usually by another script or cron job) after this line is executed, shutil.copyfile will run anyway and raise an exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added function to handle boolean true/false on parameters. Changed parameter requirements. Checked for existence of manifest.xlsx sheet before attempting to work with it. Changed assumption that 'id' column was the first column in the sheet. Added some parameter error checking. Added additional spacing between functions.