Merged
Conversation
Owner
|
LGTM, thanks for addressing the issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am trying to use
fresh-testing-libraryand found some errors when runningdeno task check.I investigated and fixed the issues. Here are the details:
Changes
1. Fix
demo/static/logo.svgformatting errordeno fmt --checkwas targetingdemo/static/logo.svg, which caused a formatting error.Fix: Added
demo/static/*tofmt.excludein deno.json.2. Fix environment variable access error
When running
deno task check:imports, ts_morph (TypeScript) internally tries to access theTS_ETW_MODULE_PATHenvironment variable, which causes a permission error:Fix: Added
--allow-env=TS_ETW_MODULE_PATHto the check:imports task.Environment