docs(scan): state the pin consequence precisely - #33
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![slopzapper[bot]](https://avatars.githubusercontent.com/in/4527847?s=60&v=4){kind=small}
There was a problem hiding this comment.
🟢 Approval recommended
The change is a documentation-only clarification in a comment and is consistent with the stated PR intent.
Pull request overview
Refines the inline workflow documentation in the shared scan workflow wrapper to accurately describe the practical effect of pinning the reused uinaf/.github workflow reference (i.e., it won’t be auto-updated and would require a manual bump).
Changes:
- Rewords the comment above the
uses: uinaf/.github/...@mainline to avoid overstating that a pin “would never move again”. - Clarifies that Renovate won’t update these references automatically, but a human can still bump the pin.
File summaries
| File | Description |
|---|---|
.github/workflows/scan.yml |
Updates explanatory comment to precisely describe pinning behavior and manual bump requirement. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The reference note said a pin "would never move again". That overstates it: Renovate is configured not to update
uinaf/.githubreferences, but a pin can still be bumped by hand. In repositories with no Renovate config of their own, attributing it to "the shared Renovate preset" also reads as though something local is responsible.Solution
Say that the reference is not updated automatically and would need a manual bump, which is the actual consequence.