ci: scan shared workflow changes - #5
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a repository-local way to exercise the shared reusable scan workflow in CI, and introduces a consistent local verification gate (via Mise) for workflow linting/security auditing.
Changes:
- Add a self-caller workflow (
self-scan.yml) that runs the repo’s reusable scan workflow on pushes, PRs, schedules, and manual dispatch. - Add
mise.tomlwith pinnedactionlintandzizmorplusmise run verifytasks for local workflow verification. - Clarify intentional ShellCheck behavior in the reusable scan workflow by suppressing SC2086 for the deliberate argument word-splitting.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Documents how to run local verification via Mise and what the self-caller does. |
| mise.toml | Adds pinned tooling and local verification tasks for workflow linting/auditing. |
| .github/workflows/self-scan.yml | Introduces a thin caller workflow to run the reusable scan workflow from this repo. |
| .github/workflows/scan.yml | Adds a ShellCheck suppression comment to preserve intentional argument splitting behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Changes to the shared scan workflow had no in-repository caller, so this repository did not exercise its own reusable contract in CI. Local workflow linting was also ad hoc.
Solution
Add a thin relative self-caller that runs the reusable workflow at the pull request exact revision. Add a source-aware Mise gate for pinned Actionlint and Zizmor, and encode the existing intentional Zizmor argument split for ShellCheck without changing scanner behavior or first-party ref policy.
Proof