Repository navigation
Update default shape border color and show style defaults - #12
Merged
Merged
Conversation
Change the default stroke for all diagram shapes from #d2d9e6 to #f4f7fc. Add a defaultColor prop to ColorPickerInput so empty values show a fallback swatch. Prefill border color, width, and opacity with their defaults, and rename "Border Transparency" to "Border Opacity".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the default border color of diagram shapes and shows the default values in the style panel.
Before and after
Before: Shapes had a
#d2d9e6border by default. The style panel showed empty border color, width and opacity fields.After: Shapes have a
#f4f7fcborder by default. The style panel shows the default border color, width and opacity, and color pickers show a default color sample when empty.Risk
Shapes with no border color set get the new color. Reverting the PR fully undoes it.
Evidence
Not tested. I did not run a build or the app.
What changed
Improvements
#f4f7fc.Checklist