Conversation
…nto antlr4-integration
rahulk29
reviewed
Mar 20, 2026
core/compiler/grammar/Argon.g4
Outdated
| | primaryExpr | ||
| ; | ||
|
|
||
| primaryExpr |
Contributor
There was a problem hiding this comment.
merge these productions into nonBlockExpr if possible
rahulk29
reviewed
Mar 20, 2026
core/compiler/grammar/Argon.g4
Outdated
Comment on lines
+203
to
+232
| kwArgs | ||
| : kwArgsTrailingComma | ||
| | kwArgsNoComma | ||
| ; | ||
|
|
||
| kwArgsTrailingComma | ||
| : kwArgValue COMMA | ||
| | kwArgsTrailingComma kwArgValue COMMA | ||
| ; | ||
|
|
||
| kwArgsNoComma | ||
| : kwArgValue | ||
| | kwArgsTrailingComma kwArgValue | ||
| ; | ||
|
|
||
| posArgs | ||
| : posArgsTrailingComma | ||
| | posArgsNoComma | ||
| ; | ||
|
|
||
| posArgsTrailingComma | ||
| : expr COMMA | ||
| | posArgsTrailingComma expr COMMA | ||
| ; | ||
|
|
||
| posArgsNoComma | ||
| : | ||
| | expr | ||
| | posArgsTrailingComma expr | ||
| ; |
Contributor
There was a problem hiding this comment.
Make this more idiomatic for ANTLR (e.g. by using ?). Reduce the number of non-terminals and productions where possible.
rahulk29
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.