Ensure all configs are used or checked in the constructor#172
Open
yushan8 wants to merge 7 commits into
Open
Conversation
liujsj
reviewed
Jul 10, 2026
| } | ||
| if config.Repository[i].QueryTimeoutSeconds <= 0 { | ||
| return nil, fmt.Errorf("repository[%d].query_timeout_seconds must be > 0", i) | ||
| } |
There was a problem hiding this comment.
Why are we removing the default values and erroring out. Should we not have default values if user do not provide for timeout or chunks?
I am not sure what the config document will look like but initial gut reaction is that we are asking users of the library to be quite knowledgable in the code base vs working out of the box
There was a problem hiding this comment.
Also if we do decide to change that these must be provided, then please update service_config comments as it mentions
// streaming chunk sizes; zero values fall back to package defaults
sbalabanov
approved these changes
Jul 10, 2026
| mockCmd.EXPECT().Wait().Return(nil), | ||
| ) | ||
| client, err := NewBazelClient(context.Background(), Params{ | ||
| QueryTimeout: 5 * time.Minute, |
Contributor
There was a problem hiding this comment.
it is better to rely on test timeout rather than hardcode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All config validation is now done in constructors. Methods no longer check for config values. Return a validation error if the config was not set.