Conversation
This is part of refactoring the core package structures to make it more sensible. Currently, our controller layer is not really a controller - that's a full on handler that bundles up the proto RPC request layer + what looks like should be 3 different controller methods: - change graph computation thru bazel - graph caching - comparison all bundled up in to a single method: GetChangedTargets. Not only that violates the service architecture, but also this whole thing makes it difficult to test and leaks RPC abstraction into various parts of the logic. Let's begin by creating a separate package for graph comparison. internal/targetdiff is an internal pkg that lets us compare targets across two changed targets graph.
xytan0056
approved these changes
Jul 9, 2026
sbalabanov
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of refactoring the core package structures to make it more sensible.
Currently, our controller layer is not really a controller - that's a full on handler that bundles up the proto RPC request layer + what looks like should be 3 different controller methods:
all bundled up in to a single method: GetChangedTargets.
Not only that violates the service architecture, but also this whole thing makes it difficult to test and leaks RPC abstraction into various parts of the logic.
Let's begin by creating a separate package for graph comparison.
internal/targetdiff is an internal pkg that lets us compare targets across two changed targets graph.