Ensure PoolSize is set in RepoManager#167
Merged
Merged
Conversation
sywhang
approved these changes
Jul 9, 2026
sywhang
requested changes
Jul 9, 2026
| // shutting down (e.g. wire it to SIGTERM/SIGINT in main) to abort any | ||
| // background goroutines the manager spawns. | ||
| func NewRepoManager(appCtx context.Context, p Params) RepoManager { | ||
| func NewRepoManager(appCtx context.Context, p Params) (RepoManager, error) { |
Contributor
There was a problem hiding this comment.
actually, since this signature's changed, all the callers have to be updated too.
sywhang
reviewed
Jul 9, 2026
sywhang
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PoolSize is a required config field. Error out in the constructor if not set.