Fix path traversal issue with storage key#164
Open
sywhang wants to merge 6 commits into
Open
Conversation
xytan0056
reviewed
Jul 9, 2026
Right now we allow arbitrary paths to be passed as the storage key in all over the place with storage layer. This lets users escape the root path with "../" prefixes which can be a security vulnerability. Fix this by validating all input sites.
sywhang
force-pushed
the
storage-key-traversal-fix
branch
from
9774b7a to
9aed309
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now we allow arbitrary paths to be passed as the storage key in all over the place with storage layer. This lets users escape the root path with "../" prefixes which can be a security vulnerability.
Fix this by validating all input sites.