feat(stovepipe): add queueconfig Store with default implementation#334
Open
mnoah1 wants to merge 1 commit into
Open
feat(stovepipe): add queueconfig Store with default implementation#334mnoah1 wants to merge 1 commit into
mnoah1 wants to merge 1 commit into
Conversation
mnoah1
force-pushed
the
mnoah1/stovepipe-process-coalesce
branch
from
1a66cd1 to
ee5ac0c
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-process-queueconfig
branch
from
4d1f951 to
c814927
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-process-coalesce
branch
from
ee5ac0c to
c1ee23a
Compare
mnoah1
force-pushed
the
mnoah1/stovepipe-process-queueconfig
branch
from
c814927 to
acdd570
Compare
behinddwalls
force-pushed
the
mnoah1/stovepipe-process-coalesce
branch
from
c1ee23a to
7003035
Compare
Introduce queueconfig.Store and wire process to resolve per-queue max_concurrent at gate-check time. The default store returns global wiring constants; admit lands in a follow-up PR.
behinddwalls
force-pushed
the
mnoah1/stovepipe-process-queueconfig
branch
from
acdd570 to
98cef3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Introduce queueconfig.Store and wire process to resolve per-queue max_concurrent for use when checking if we are ready to admit another build.
Why?
MVP logic to enqueue builds has two constants that will need to become configurable per queue in the future:
Test Plan