Skip to content

feat(stovepipe): add Queue entity#309

Merged
mnoah1 merged 2 commits into
mainfrom
mnoah1/stovepipe-queue-entity
Jul 8, 2026
Merged

feat(stovepipe): add Queue entity#309
mnoah1 merged 2 commits into
mainfrom
mnoah1/stovepipe-queue-entity

Conversation

@mnoah1

@mnoah1 mnoah1 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Why?

Implementing process step.

This change creates a Queue entity to keep track of queue-level state. This matches the spec outlined in: https://github.com/uber/submitqueue/blob/main/doc/rfc/stovepipe/steps/process.md#queue-new-persisted-entity

What?

Add the per-queue Queue entity that backs the process stage's concurrency gate and backlog coalescing.

Test Plan

-Subsequent PRs will build out functionality that we can test

@behinddwalls

Copy link
Copy Markdown
Collaborator

⚠️ Automatic stack rebase failed

This PR could not be automatically rebased after its base PR was merged. The rebase hit conflicts that need manual resolution.

To fix manually:

git fetch origin
git checkout mnoah1/stovepipe-queue-entity
git rebase --onto origin/main c9acfbf57688aa0ed815fdfd64868d58fb64d1aa mnoah1/stovepipe-queue-entity
# resolve conflicts, then:
git push --force-with-lease

Then update this PR's base branch:

gh pr edit 309 --base main

Base automatically changed from mnoah1/process-docs-update to main July 8, 2026 15:38
@mnoah1 mnoah1 force-pushed the mnoah1/stovepipe-queue-entity branch from cf251a2 to bc8acfc Compare July 8, 2026 15:45
@mnoah1 mnoah1 marked this pull request as ready for review July 8, 2026 15:47
@mnoah1 mnoah1 requested review from a team, behinddwalls and sbalabanov as code owners July 8, 2026 15:47
@mnoah1 mnoah1 enabled auto-merge July 8, 2026 15:47
@mnoah1 mnoah1 changed the title feat(stovepipe): add Queue coordination entity feat(stovepipe): add Queue entity Jul 8, 2026
Comment thread stovepipe/entity/queue.go
Comment thread stovepipe/entity/queue.go Outdated
@mnoah1 mnoah1 added this pull request to the merge queue Jul 8, 2026
Merged via the queue into main with commit 953fe4b Jul 8, 2026
15 checks passed
@mnoah1 mnoah1 temporarily deployed to stack-rebase July 8, 2026 16:47 — with GitHub Actions Inactive
@behinddwalls behinddwalls deleted the mnoah1/stovepipe-queue-entity branch July 8, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants