[OPE] Pass RuntimeOptions to the worker process#363
Merged
Conversation
15f3c60 to
6e0a3c4
Compare
Codecov Report
@@ Coverage Diff @@
## master #363 +/- ##
==========================================
+ Coverage 89.41% 89.44% +0.03%
==========================================
Files 57 57
Lines 3900 3913 +13
==========================================
+ Hits 3487 3500 +13
Misses 413 413
Continue to review full report at Codecov.
|
selitvin
approved these changes
May 28, 2020
6e0a3c4 to
137a13e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR passes user-specified
RuntimeOptionsto the OPE worker process when loading a model.This enables us to easily add options without having to write special logic for OPE.
See #361 and #364 for examples.