Accept any transfer-encoding ending in chunked - #1943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since v20.70.0 a request whose
Transfer-Encodingends inchunkedbut is not exactly the stringchunkedis refused with 400.HttpParser.hcompares the whole header value against the literal,so
gzip, chunkedis rejected, and so isChunked.Both are valid. RFC 9112 section 6.1 allows a list of transfer codings and requires only that
chunkedbe the final one, and section 7 makes transfer-coding names case-insensitive. Clients thatcompress and then chunk send the list form, so this refuses well-formed requests.
The check now lowercases the value in place and tests that it ends with
chunkedrather than equalsit, which accepts the list form and any casing while still refusing a value where
chunkedis absentor not final. Preceding codings are left to the application, as before: what the parser needs to know
is that the framing is chunked.
Fixes #1941