send configuration settings in testConnection #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
send configuration settings in testConnection()
testConnection() now sends config settings. So, it had to be moved to AFTER the setup of ConfigRegShdw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello: This is the first time I've used github to contribute to community.
I used this library on MCP3425. The non-blocking routines work, but weird stuff happened when I tried using them without sending the configuration bit first in setup(). That isn't abundantly clear during its use.
So, in preparation of me submitting a ReadLoop_NonBlocking.ino example code, this small change is needed.