Add log4j example. - #30
Open
JurajBurian wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi mr. Seeberger,
I must apologize for new Pull request, but I am still confused from git (sweet SVN for me :-) ).I have still problem with collapse commits into one. I need probably some advice.
Please forgot my first pull request.
I hope that mine last commit (still not one) will be ok.
I am not sure with this line:
libraryDependencies ++= Seq(Dependencies.Test.log4jCore),
but in mine opinion this way is right, because log4jCore dependency is used only in scalalogging-log4j-test project.
I will write similar example for slf4j logging ok?
again, sorry for inconvenience.
JuBu