Conversation
Contributor
|
Sorry I was mass-closing PRs! Please rewrite the PR description to address the functional change. |
Author
|
Updated the PR description to explicitly document the functional change and preserved behavior. I also merged the latest main; all CI checks are passing now. |
Contributor
|
ok I believe this is a good change but I will hold off with merging for now for internal reasons. I'll get back to this. Same with your other PRs. Thanks! |
Contributor
|
We will also be rolling out an AI policy to forbid agent-human communication in our repositories in the future. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100
Functional change
When
all_packages=Trueand Dagger codegen is enabled, codegen previously ran only at the workspace root (.). Local workspace members selected byall_packagestherefore did not have their generated SDK files materialized beforeuv sync.This change runs codegen once for every reachable local workspace member when
all_packages=True.Behavior preserved
package=[...]selections still run codegen only for the selected local packages...Implementation
uv.lock.pyproject.tomlfiles in the source tree.Verification
PYTHONPATH=uv/src pytest -q uv/tests— 141 passed after merging currentmainruff check uv/src uv/tests— passedruff format --check uv/src uv/tests— passed