Skip to content

fix(uv): run codegen for all workspace packages - #103

Open
Kewe63 wants to merge 2 commits into
typesafe-ai:mainfrom
Kewe63:fix/uv-all-packages-codegen
Open

Kewe63 wants to merge 2 commits into
typesafe-ai:mainfrom
Kewe63:fix/uv-all-packages-codegen

Conversation

@Kewe63

@Kewe63 Kewe63 commented Sep 19, 2026 •

Copy link
Copy Markdown

Fixes #100

Functional change

When all_packages=True and Dagger codegen is enabled, codegen previously ran only at the workspace root (.). Local workspace members selected by all_packages therefore did not have their generated SDK files materialized before uv sync.

This change runs codegen once for every reachable local workspace member when all_packages=True.

Behavior preserved

  • Explicit package=[...] selections still run codegen only for the selected local packages.
  • Explicit package order and deduplication are preserved.
  • A standalone/default-root package still runs codegen at ..
  • Lockfile entries that are outside the source tree or otherwise unreachable are ignored.

Implementation

  • Parse local package paths from uv.lock.
  • Match them against reachable pyproject.toml files in the source tree.
  • Use the resulting paths as codegen targets before local-package discovery.

Verification

  • PYTHONPATH=uv/src pytest -q uv/tests — 141 passed after merging current main
  • ruff check uv/src uv/tests — passed
  • ruff format --check uv/src uv/tests — passed

@danielgafni

Copy link
Copy Markdown
Contributor

Sorry I was mass-closing PRs!

Please rewrite the PR description to address the functional change.

@danielgafni danielgafni reopened this Sep 25, 2026
@Kewe63

Kewe63 commented Sep 25, 2026

Copy link
Copy Markdown
Author

Updated the PR description to explicitly document the functional change and preserved behavior. I also merged the latest main; all CI checks are passing now.

@danielgafni

Copy link
Copy Markdown
Contributor

ok I believe this is a good change but I will hold off with merging for now for internal reasons. I'll get back to this. Same with your other PRs. Thanks!

@danielgafni

Copy link
Copy Markdown
Contributor

We will also be rolling out an AI policy to forbid agent-human communication in our repositories in the future.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

all_packages=True skips Dagger codegen for workspace members

2 participants