Conversation
Contributor
|
Sorry I was mass-closing PRs! Please rewrite the PR description to address the functional change. |
Author
|
Updated the PR description to explicitly document the functional change and preserved behavior. I also merged the latest main; all CI checks are passing now. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99
Functional change
RuffChecker.fixandRuffFormatter.fixpreviously accepted any Ruff process exit status. As a result, usage errors, invalid configuration, and runtime failures could be reported as successfulChangesetresults.This change restores fail-closed execution for both fix operations.
Behavior preserved
RuffChecker.fixstill returns a Changeset when fixes are applied but ordinary lint violations remain.--exit-zerooption.Implementation
expect=dagger.ReturnType.ANYfrom checker and formatter execution.--exit-zeroonly toruff check --fix.Verification
PYTHONPATH=ruff/src pytest -q ruff/tests— 37 passed after merging currentmainruff check ruff/src ruff/tests— passedruff format --check ruff/src ruff/tests— passed--exit-zeroreturn exit 0