Conversation
Contributor
|
Sorry I was mass-closing PRs! Please rewrite the PR description to address the functional change. |
Author
|
Updated the PR description to explicitly document the functional change and preserved behavior. I also merged the latest main; all CI checks are passing now. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98
Functional change
GithubStatusMonitor.wait_for_statusespreviously flattened commit statuses and check runs into a single map keyed only by display name. If both GitHub API channels reported a check with the same name, the check run overwrote the commit status and the expected checks were deduplicated.A failed commit status named
buildcould therefore be hidden by a successful check run namedbuild, causing the monitor to report success after observing only one effective check.This change preserves the GitHub API channel as part of each check's identity. A same-named commit status and check run are now tracked independently, and a failure in either channel prevents success.
Behavior and output
checksandcheck_runsinputs remain unchanged.status: buildandcheck run: build.Implementation
Checkidentity.wait_for_statusesregressions covering same-named failures and successful checks in both channels.Verification
PYTHONPATH=github/src pytest -q github/tests— 55 passed after merging currentmainruff check github/src github/tests— passedruff format --check github/src github/tests— passed