Internal improvements 9 - #34
Merged
Merged
Conversation
rcalicdan
commented
Aug 17, 2026
rcalicdan
commented
Member
- Major bug fixes
- Improve generics documentations
- Improve internal code quality by refactoring code to adhere to SRP
- Improve test coverage
…leService and enhance tests for type validation
…arios and validations
… methods and improve unit tests for better coverage
…ed handling of hooks and docblock annotations - Simplified the process of skipping injection for properties with no hooks or specific ignore tags in PropertyHookInjector. - Extracted logic for processing 'get' and 'set' hooks into separate methods for better readability and maintainability. - Enhanced tests for PropertyHookInjector to cover various scenarios including handling of ignore tags and custom parameter names. - Updated FunctionContractInjector tests to ensure proper injection of checks based on docblock annotations, including support for generator functions and lifecycle methods. - Improved test structure for clarity and consistency across different scenarios.
… for function, property, and magic method parsing
- Updated ContractParserTest to enhance readability by adding line breaks for better separation of assertions. - Enhanced SpecialTypeResolverTest with additional test cases for handling $this identity checks and resolving special identifier keywords. - Improved TemplateManagerTest by restructuring tests into descriptive groups, adding tests for inherited template resolution, and validating variance rules. - Expanded TemplateSubstitutorTest to include substitutions for CallableTypeNode, ConditionalTypeNode, and ObjectShapeNode, ensuring comprehensive coverage of template placeholder substitutions.
…eadability in the callable type substitution test
…rting modern testing utilities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.