Issue #14, #15 patch - #17
Merged
Merged
Conversation
…es for baseline test before implementing patches
…or to prevent overwriting existing aliases
…ions using anonymous classes
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #14 and #15 by ensuring class-level type aliases are resolved for properties and enhancing error message precision for nested array shapes within Union types.
1. Fix Class-Level Type Alias Resolution for Properties (#14)
ContractParser::parseProperty()previously only extracted aliases from the property's local@vardocblock. It omitted class-level@phpstan-typeand@phpstan-import-typedeclarations from the class hierarchy, causing properties using imported aliases (e.g.,list<PluginInfo>) to fail resolution and fall back to class-name checks (must be of type PluginInfo).ContractParser::parseProperty()andparseClassAliases()to pre-load all inherited/imported class-level aliases viaparseClassLevelDocs().DocblockExtractor::extractAliases()with!isset()checks to ensure child-class alias definitions take precedence over parent definitions during hierarchy traversal.2. Preserve Deep Structural Errors in Union Validation (#15)
array{...} | null),UnionValidatorpreviously discarded inner structural failure messages if all branches failed. It outputted a generic top-level error (must be of type (array{...} | null)), masking the exact failing nested array key or property.UnionValidatorto detect and prioritize deep structural errors (e.g.,$payload['args'][2] must be...oris missing required key).UnionValidatornow surfaces that specific error instead of falling back to the generic union message.resolve #14, Closes #15