TracedHandler should use an existing Local[F, Span[F]]#591
Open
bpholt wants to merge 4 commits intotypelevel:mainfrom
Open
TracedHandler should use an existing Local[F, Span[F]]#591bpholt wants to merge 4 commits intotypelevel:mainfrom
bpholt wants to merge 4 commits intotypelevel:mainfrom
Conversation
8b1f7e1 to
db98aad
Compare
Member
Author
|
Rebased and now it successfully builds! |
db98aad to
4c217bd
Compare
…Impl this allows for Scala version-specific interfaces but without duplicating the implementation logic
bpholt
commented
Oct 21, 2025
|
|
||
| trait TracedHandlerPlatform: | ||
| def apply[F[_]: MonadCancelThrow, Event, Result](entryPoint: EntryPoint[F])( | ||
| handler: Trace[F] ?=> F[Option[Result]])( |
Member
Author
There was a problem hiding this comment.
Splitting the apply method into Scala version-specific files lets us use a context function here, which improves the experience on Scala 3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a Lambda with an initialization
Resourcethat (simplified) looks like this:When I went to use
TracedHandler.apply, I noticed that it was constructing its ownIOLocalto hold the trace state. I don't think that will be in sync with thegiven Local[IO, Span[IO]] <- IO.local(Span.noop[IO])built in the resource, and I want them to be in sync because I want theClient[F]to have the same trace state as the rest of the handler, so I think we need a new way to build aTracedHandlerthat can inherit the ambientLocal[F, Span[F]].I started off by adding this as a separate
TracedHandler.localmethod, but I didn't think that was a particularly good name, so I ended up basically replacingTracedHandler.apply(in a binary-compatible way).