Add ApplicationLoadBalancerRequestEvent by ngwin-ab · Pull Request #590 · typelevel/feral

ngwin-ab · 2025-10-14T16:33:55Z

Added Application Load Balancer Request Event as part of #48, all tests passed.

Reference for event specifications:
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/aws-lambda/trigger/alb.d.ts

ngwin-ab · 2025-10-14T17:04:46Z

hi @armanbilge : Could you please review this PR? Thank you!

lambda/shared/src/test/scala/feral/lambda/events/ApplicationLoadBalancerRequestEventSuite.scala

lambda/shared/src/main/scala/feral/lambda/events/ApplicationLoadBalancerRequestEvent.scala

ngwin-ab · 2025-10-22T22:06:07Z

@bpholt : hi Brian, thanks for reviewing the PR! I was away from my laptop last week and did not have a chance to work on this until now. I've updated the PR to address your comments, could you please take a look? Thank you!

ngwin-ab · 2025-10-23T17:22:42Z

@armanbilge : hi Arman, could you please review this PR when you have time? Thank you!

lambda/shared/src/main/scala/feral/lambda/events/ApplicationLoadBalancerRequestEvent.scala

armanbilge · 2025-10-23T18:56:53Z

lambda/shared/src/main/scala/feral/lambda/events/ApplicationLoadBalancerRequestEvent.scala

+  private implicit val mapStringDecoder: Decoder[Map[CIString, String]] =
+    Decoder.decodeMap[CIString, String]
+  private implicit val mapListDecoder: Decoder[Map[CIString, List[String]]] =
+    Decoder.decodeMap[CIString, List[String]]


Hmm, are you sure these are necessary? I feel surprised/confused.

They are not called directly in the code, they are used implicitly by Circe's Decoder when decoding JSON into an ApplicationLoadBalancerRequestEvent instance

Can you please double-check? I tried removing them, and it looks like the code still compiles.

lambda/shared/src/test/scala/feral/lambda/events/ApplicationLoadBalancerRequestEventSuite.scala

ngwin-ab · 2025-10-24T13:39:35Z

@armanbilge : I've addressed the review comments, could you please take a look?

armanbilge · 2025-10-31T17:10:15Z

lambda/shared/src/test/scala/feral/lambda/events/ApplicationLoadBalancerEventSuite.scala

+    val encodedBody =
+      java.util.Base64.getEncoder.encodeToString("hello world".getBytes("UTF-8"))


scodec-bits has a nice syntax for this:

Suggested change

val encodedBody =

java.util.Base64.getEncoder.encodeToString("hello world".getBytes("UTF-8"))

val encodedBody = asciiBytes"hello world".toBase64

armanbilge · 2025-10-31T17:25:39Z

lambda/shared/src/main/scala/feral/lambda/events/ApplicationLoadBalancerRequestEvent.scala

+import org.typelevel.ci.CIString
+import scodec.bits.ByteVector
+
+sealed abstract class Elb {


Maybe this name is more clear :)

Suggested change

sealed abstract class Elb {

sealed abstract class ElasticLoadBalancer {

armanbilge · 2025-10-31T17:39:04Z

lambda/shared/src/main/scala/feral/lambda/events/ApplicationLoadBalancerRequestEvent.scala

+  private implicit val mapStringDecoder: Decoder[Map[CIString, String]] =
+    Decoder.decodeMap[CIString, String]
+  private implicit val mapListDecoder: Decoder[Map[CIString, List[String]]] =
+    Decoder.decodeMap[CIString, List[String]]


Can you please double-check? I tried removing them, and it looks like the code still compiles.

armanbilge · 2025-10-31T17:40:25Z

lambda/shared/src/main/scala/feral/lambda/events/ApplicationLoadBalancerRequestEvent.scala

+object Elb {
+  def apply(targetGroupArn: String): Elb = Impl(targetGroupArn)
+
+  implicit val decoder: Decoder[Elb] = Decoder.forProduct1("targetGroupArn")(Elb.apply)


Suggested change

implicit val decoder: Decoder[Elb] = Decoder.forProduct1("targetGroupArn")(Elb.apply)

private[events] implicit val decoder: Decoder[Elb] = Decoder.forProduct1("targetGroupArn")(Elb.apply)

armanbilge · 2025-10-31T17:40:34Z

lambda/shared/src/main/scala/feral/lambda/events/ApplicationLoadBalancerRequestEvent.scala

+  def apply(elb: Elb): ApplicationLoadBalancerRequestContext =
+    Impl(elb)
+
+  implicit val decoder: Decoder[ApplicationLoadBalancerRequestContext] =


Suggested change

implicit val decoder: Decoder[ApplicationLoadBalancerRequestContext] =

private[events] implicit val decoder: Decoder[ApplicationLoadBalancerRequestContext] =

armanbilge · 2025-10-31T17:44:53Z

lambda/shared/src/test/scala/feral/lambda/events/ApplicationLoadBalancerEventSuite.scala

+      queryStringParameters = Some(Map("query" -> "1234ABCD")),
+      headers = Some(
+        Map(
+          org.typelevel.ci.CIString("accept") -> "text/html,application/xhtml+xml",


There is a special syntax to shorten this.

Suggested change

org.typelevel.ci.CIString("accept") -> "text/html,application/xhtml+xml",

ci"accept" -> "text/html,application/xhtml+xml",

armanbilge · 2025-10-31T17:47:09Z

lambda/shared/src/test/scala/feral/lambda/events/ApplicationLoadBalancerEventSuite.scala

+    assert(
+      decoded
+        .bodyDecoded
+        .exists(_ == ByteVector.encodeUtf8("hello world").getOrElse(ByteVector.empty)))


Suggested change

assert(

decoded

.bodyDecoded

.exists(_ == ByteVector.encodeUtf8("hello world").getOrElse(ByteVector.empty)))

assertEquals(decoded.bodyDecoded, Some(asciiBytes"hello world"))

ngwin-ab added 5 commits October 14, 2025 11:27

added ApplicationLoadBalancerRequestEvent model

56aec7f

updated for consistency with other event types

25b7b8b

added tests suite

ba95f35

dummy commit to trigger build

85aee56

formatted code to fix scalafmt check

fd5316c

ngwin-ab marked this pull request as ready for review October 14, 2025 17:04

bpholt reviewed Oct 14, 2025

View reviewed changes

lambda/shared/src/test/scala/feral/lambda/events/ApplicationLoadBalancerRequestEventSuite.scala Outdated Show resolved Hide resolved

bpholt reviewed Oct 14, 2025

View reviewed changes

lambda/shared/src/test/scala/feral/lambda/events/ApplicationLoadBalancerRequestEventSuite.scala Outdated Show resolved Hide resolved

bpholt reviewed Oct 14, 2025

View reviewed changes

lambda/shared/src/main/scala/feral/lambda/events/ApplicationLoadBalancerRequestEvent.scala Outdated Show resolved Hide resolved

ngwin-ab added 5 commits October 22, 2025 15:40

made map decoders private

2cbbeed

updated tests to compare decoded event with expected value

3e77117

added helper method to decode the body if it is base64-encoded

e0d2bff

formatted code

d62086e

formatted code

babc30f

ngwin-ab added 5 commits October 23, 2025 11:54

added test for helper method

b23c456

removed nowarn annotation

f2521ce

removed unused import

33a6b4d

removed unused import

ad2a0f9

fixed format

71b6567

armanbilge reviewed Oct 23, 2025

View reviewed changes

ngwin-ab added 6 commits October 23, 2025 14:15

corrected the code following the review comments

789d714

reformatted the code

fbabd37

fixed the test and format of the files

4f219a8

format the code again

829f70a

renamed test suite

0c09c43

renamed test suite

042cd17

armanbilge reviewed Oct 31, 2025

View reviewed changes

		val encodedBody =
		java.util.Base64.getEncoder.encodeToString("hello world".getBytes("UTF-8"))

	val encodedBody =
	java.util.Base64.getEncoder.encodeToString("hello world".getBytes("UTF-8"))
	val encodedBody = asciiBytes"hello world".toBase64

	sealed abstract class Elb {
	sealed abstract class ElasticLoadBalancer {

	implicit val decoder: Decoder[Elb] = Decoder.forProduct1("targetGroupArn")(Elb.apply)
	private[events] implicit val decoder: Decoder[Elb] = Decoder.forProduct1("targetGroupArn")(Elb.apply)

	implicit val decoder: Decoder[ApplicationLoadBalancerRequestContext] =
	private[events] implicit val decoder: Decoder[ApplicationLoadBalancerRequestContext] =

	org.typelevel.ci.CIString("accept") -> "text/html,application/xhtml+xml",
	ci"accept" -> "text/html,application/xhtml+xml",

Uh oh!

Conversation

ngwin-ab commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ngwin-ab commented Oct 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ngwin-ab commented Oct 22, 2025

Uh oh!

ngwin-ab commented Oct 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ngwin-ab commented Oct 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ngwin-ab commented Oct 14, 2025 •

edited

Loading