Skip to content
This repository was archived by the owner on Dec 31, 2022. It is now read-only.

feat: Update Component Generator for Colocation - #161

Open
Alonski wants to merge 2 commits into
typed-ember:masterfrom
Alonski:patch-1
Open

Alonski wants to merge 2 commits into
typed-ember:masterfrom
Alonski:patch-1

Conversation

@Alonski

@Alonski Alonski commented Feb 1, 2020

Copy link
Copy Markdown

No description provided.

@lifeart

lifeart commented Feb 9, 2020

Copy link
Copy Markdown

@Alonski trying this pr in my repo, I suppose ember g component name -ns should generate only template, but it's generating index,{hbs,ts} without @glimmer/component import.

@Alonski

Alonski commented Feb 9, 2020

Copy link
Copy Markdown
Author

Thanks for testing @lifeart
This isn't really ready yet. I'm not sure if I'll keep working on it.

@lifeart

lifeart commented Feb 9, 2020

Copy link
Copy Markdown

@Alonski at least, I really need this blueprint for octane app demo xD.
I beleve there is the plans to add support for such functionality, but, I think it's possible to create minimal addon blueprint, like ember-octane-typescript-component and use this MR inside it (owerriding ember-cli-typescript-blueprints component, and adding component-class blueprints).

And once ts team will be ready, we can backport features to this repo or such.

Users already using ts and octane, and I think we have to provide an option to avoid manual boilerplating. And it's doesn't really matter where it's located.

@chriskrycho

Copy link
Copy Markdown
Member

@Alonski this has obviously been sitting for way too long. We'd be happy to help you land it, at least as a stopgap while we iterate toward a new and better approach for blueprints. If you'd prefer we just close it, we can do that, too!

@lifeart

lifeart commented Nov 16, 2020

Copy link
Copy Markdown

@chriskrycho since now we have builtin way to enable typescript compilation (in ember-cli-babel), I wondering, could we move this blueprints into ember scope, to simplify maintance & upstreaming? (or use existing .js blueprints with some if's, related to .ts?

cc @Alonski

@chriskrycho

Copy link
Copy Markdown
Member

Can't move it into Ember scope until we go through an RFC process to make TS support official. 😉 However, working from/with existing .js blueprints is indeed what we're aiming toward medium term.

@lifeart

lifeart commented Nov 16, 2020

Copy link
Copy Markdown

in my understanding, for mid-term period, it may be an fork of default ember templates, with patch after RFC will be merged? trying to figure out maintainable & easy to iterate approach

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants