Repository navigation
feat(contracts): add one shape and primitive registry - #11
Merged
Merged
Conversation
cursor
Bot
force-pushed
the
cursor/pr-registry-85a6
branch
from
October 4, 2026 21:08
a3cd5ce to
88d7348
Compare
JSON owns the twelve shapes and ten primitives. The new checker fails when SKILL.md, references, examples, or the harness disagree, and when podcast.html still says nine or eleven. Co-authored-by: Todd Dailey <twidtwid@users.noreply.github.com>
Comment Sicko: usage header restates the script. Duplicate drift tests overwrote each other. Rename says a JSON drop fails while the skill still names the shape. Co-authored-by: Todd Dailey <twidtwid@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/pr-registry-85a6
branch
from
October 4, 2026 22:17
88d7348 to
a8eb3c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Adding a shape still means editing the skill, a reference file, an example, the gallery, the harness map, and a test count by hand. Those lists drift.
examples/podcast.htmlstill said nine shapes and eleven examples.What changed
contracts/shapes.jsonandcontracts/primitives.jsonown the twelve shapes and ten primitives.scripts/check-contracts.mjsfails when SKILL.md, references, examples, or the harness disagree with those files.Scope
This PR only adds the registry and the drift gate. It does not require
data-shapeon generated HTML and does not add--against. Checklist and podcast-transcript stay out of the shape list.Tradeoffs
The harness used to hardcode
SHAPE_REFERENCES. Loading JSON is the smaller way to keep one list.Blast Radius
make checknow runs the new checker. A missing example or a stale nine/eleven string fails CI. Podcast briefing text changed. Interactive behavior did not.Verification
node scripts/check-contracts.mjsexits 0 and prints 12 shapes and 10 primitives.examples/dashboard.htmlnamesdashboard. Restoring the nine/eleven strings namesexamples/podcast.html.make checkis green.skill_md.total_tokensstays 12241.