Repository navigation
fix(check-versions): watch execution-log and deck-review stamps - #10
Merged
Merged
Conversation
Comment Sicko: the docstring restated PR #9 and the two OK asserts. Co-authored-by: Todd Dailey <twidtwid@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #9 stamped
examples/execution-log.htmlandexamples/deck-review.htmlat v2.8.0 and left them out ofFILES. A later bump can drift those footers andmake checkstill passes. Plan 009 already shipped in5b4af3f. The plans index still said TODO.What changed
scripts/check-versions.mjsnow lists both new examples.tests/test_linters.pyfails when the checker no longer printsOKfor those two paths.plans/README.mdmarks plan 009 DONE at5b4af3f.Scope
This PR only closes the version-list hole and the stale plan-009 row. It does not add a contract registry or change generated HTML.
Blast Radius
The version checker reads two more footers. Existing stamps already match
2.8.0. Skill token count is unchanged.Verification
node scripts/check-versions.mjsprintsOKfor both new files and exits 0.make checkis green.skill_md.total_tokensstays 12241.