[WIP] Use all flake outputs#19
Draft
aciceri wants to merge 1 commit into
Draft
Conversation
Author
|
Just for adding a bit of context: we wrote an Hercules CI effect that pushes arbitrary derivations to self-hosted attic caches and I was considering |
Contributor
|
That's a good point. I've made a feature request that we can add to the roadmap: #21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I expected
nixtractto give out the graph of derivations for all the derivations between outputs, instead of just consideringpackages,legacyPackagesanddefaultPackage.In the use case we were thinking to use this in I needed all the derivations indeed, changes in this PR should do it.
This is a big change so perhaps you want this guarded by a cli flag? In my opinion this should be the default but perhaps I'm missing your use case for this project.
Notice that the hardcoded list of outputs could be not exhaustive. Also I believe it would be nice a more versatile version of
--target-attribute-pathbut I'm not sure about the interface.When (and if) this will be merged it could be interesting using it.
At the beginning it seemed that my changes worked but then I found something unexpected, currently I commented out all the outputs except
nixosConfigurationsbecause I noticed something weird.For instance if I run
nix run .#default -- --target-flake-ref "github:aciceri/nixfleet" -(that is my personal flake with my NixOS configurations, I suggest to try with something smaller if you don't want to build/fetch a lot of stuff) I get the following:Why only 2 derivations? Shouldn't
nixtractlist the closure recursively?@GuillaumeDesforges