Skip to content

Drop deprecated .alert-dismissible remaining usage#42520

Open
julien-deramond wants to merge 1 commit into
v6-devfrom
v6-dev-jd-drop-deprecated-alert-dismissible
Open

Drop deprecated .alert-dismissible remaining usage#42520
julien-deramond wants to merge 1 commit into
v6-devfrom
v6-dev-jd-drop-deprecated-alert-dismissible

Conversation

@julien-deramond

@julien-deramond julien-deramond commented Jun 16, 2026

Copy link
Copy Markdown
Member

Description

Spotted by #42487.

The .alert-dismissible class is not needed anymore for the Alert component, as the close button (or any other things) can be used associated to the use of the .ms-auto class:

  • Alert docs is updated to reflect the right DOM in the "Dismiss" section, but also to not mention anymore .alert-dismissible
  • The migration guide is improved to reference that
  • The Cheatsheet example is fixed
  • The visual tests are fixed too
Screenshot 2026-06-16 at 22 04 53

Live previews


<div class="alert theme-warning alert-dismissible fade show" role="alert" style="transition-duration: 5s;">
<button type="button" class="btn-close" data-bs-dismiss="alert" aria-label="Close"></button>
<div class="alert theme-warning fade show" role="alert" style="transition-duration: 5s;">

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not related to this PR, but this doesn't work anymore compared to v5 @mdo. I can create an issue to track it.

@julien-deramond julien-deramond requested a review from mdo June 16, 2026 20:07
@julien-deramond julien-deramond marked this pull request as ready for review June 16, 2026 20:07
@julien-deramond julien-deramond requested a review from a team as a code owner June 16, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

1 participant