Use min/max width to prevent Close button collapsing in flex containers#42518
Open
julien-deramond wants to merge 1 commit into
Open
Use min/max width to prevent Close button collapsing in flex containers#42518julien-deramond wants to merge 1 commit into
julien-deramond wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
In Alert > Dismiss, if the content more than one line, and is big, there's a rendering issue with the close button:
However, when we use a regular button, or an icon button, the rendering turns out OK:
Fix
The close button used
widthandheightset to--btn-close-size (1.5rem). These hard dimensions seems to be ignored as a minimum constraint by flex, as a flex container can shrink the button below that size when its flex-shrink kicks in.Replacing
width/heightwithmin-width/min-heightensures the button never collapses below its intended size in any flex layout (e.g. alert dismiss rows, drawer headers), while still allowing it to grow if needed.Non-regression testing
I've quickly looked at components and docs using this Close button and haven't spotted any issues, but it might worth double-check.
Live previews