Skip to content

Extend SDF conversion#109

Merged
MatthijsBurgh merged 6 commits intomasterfrom
update
Jan 7, 2023
Merged

Extend SDF conversion#109
MatthijsBurgh merged 6 commits intomasterfrom
update

Conversation

@MatthijsBurgh
Copy link
Copy Markdown
Member

Review commits separately

Used to generate tue-robotics/ed_tutorials#10

Comment on lines 9 to 11
import rospkg

rospack = rospkg.RosPack()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not used anymore correct?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are indeed not using them right now. But I think this is still useful code.

Comment thread src/ed_object_models/conversion_sdf.py
Comment thread src/ed_object_models/conversion_sdf.py Outdated
Comment thread src/ed_object_models/conversion_sdf.py
Comment thread src/ed_object_models/conversion_sdf.py
Comment thread src/ed_object_models/conversion_sdf.py
@MatthijsBurgh MatthijsBurgh merged commit 1fc1857 into master Jan 7, 2023
@MatthijsBurgh MatthijsBurgh deleted the update branch January 7, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants