fix: add --skip-git-repo-check to review tool handler#190
Conversation
The ReviewToolHandler.execute() method was missing the --skip-git-repo-check flag
that CodexToolHandler.execute() includes. This caused the review tool to fail with:
Not inside a trusted directory and --skip-git-repo-check was not specified.
when invoked via MCP from a parent orchestrator (e.g., Claude Code) even when the
directory is trusted in ~/.codex/config.toml.
This fix adds --skip-git-repo-check to the review command args, matching the
behavior of the codex (exec) tool handler.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe ReviewToolHandler's Codex command construction now includes the ChangesReviewToolHandler CLI Flag
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bug Fix
The review tool handler does not pass --skip-git-repo-check to the Codex CLI, while the codex (exec) tool handler does. This causes review to fail with the trust directory error when invoked via MCP from a parent orchestrator.
Fix
Add --skip-git-repo-check to the review command args in ReviewToolHandler.execute(), matching the behavior of CodexToolHandler.execute().
Testing
Summary by CodeRabbit