fix(publish): pass the release app private key to gh on stdin - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
set_release_secretsrangh secret set RELEASE_APP_PRIVATE_KEY --body "$RELEASE_APP_PRIVATE_KEY", which put the GitHub App private key on argv. Any user on the host could read it throughpsor/proc/<pid>/cmdlinewhile the command ran.The key now reaches
ghon stdin.gh secret set --helpdocuments this:--body … (reads from standard input if not specified).common/install.shalready passes the ghcr token todocker login --password-stdinthe same way.RELEASE_APP_IDis not a secret and stays on--body.For reference, immich (351be95) has no script that sets secrets. Its maintainers set them in the GitHub UI, and its workflows only read them.
How it was verified
tests/publish.bats"the release app private key reaches gh on stdin, never on argv". With--bodyit failed ([ "$output" = 0 ], the key was in the gh argv log), and with the fix it passes.bats tests/publish.batspasses 15/15.mise run lintpasses.Checklist
mise run lintpassesmise run test-runnerpasses — publish.bats is unit-lane; CI runs both lanes