fix: close the final review of the shell and comment cleanup - #30
Merged
Merged
Conversation
added 4 commits
September 17, 2026 03:02
A failed `cd "$dir"` inside pnpm_install's subshell ran on the left of `||`, where errexit is off, so the install went on to run in the caller's directory and reported success. Guard the cd and add a regression test that stubs pnpm and points pnpm_install at a nonexistent directory.
apply_service_dockerfile's `found` flag was never read for anything that changed behaviour: `((found == 1)) || return 0` returned 0 either way.
add-an-adapter.md pointed at a comment above `reconcile=` in `scaffold`, which no longer exists; the blind line-delete it describes is restore_pnpm_workspace in lib/pnpm.sh now. CONTRIBUTING.md still described the lint gate as shellcheck alone over a handful of directories; it runs shellcheck + shfmt over every tracked shell file.
- services/shared/nest.sh: fix a sentence that no longer parses
("unset the first `pnpm add` below" -> "otherwise the first
`pnpm add` below").
- adapters/laravel-{api,inertia}/.env.example: LOG_CHANNEL's comment
had the reason backwards — it exists because storage/logs is
unreadable in a container, not because the probe logs there.
- common/docs/mise.toml, common/mise.root.toml,
common/pnpm-workspace.yaml: qualify bare "(ADR-00NN)" references as
"(toolbox ADR-00NN)" — a generated project's own docs/decisions/
ships only 0000.
- tests/new-laravel-api.bats, tests/new-project.bats, tests/service.bats,
tests/wizard.bats, services/shared/nest.sh,
services/mongodb/drivers/laravel.sh: rewrite history-shaped comments
("used to", "measured", "before this pin") in present tense as what
they guard against.
- services/{mongodb,mysql,postgres}/drivers/*.sh and tests/service.bats:
give every `shellcheck source=/dev/null` a fixed source= path where
the sourced file is constant, or a same-line reason where it varies.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Fixes from the final whole-branch review of #25–#29.
lib/pnpm.sh(pnpm_install): thecd "$dir"inside( … ) || status=$?had no guard, and errexit is off in that position. A missing app directory ranpnpm install --no-frozen-lockfilein the caller's directory and reported success. It is nowcd "$dir" || exit 1. The newtests/pnpm.batsfails without the fix and is added totest-unit.lib/service.sh(apply_service_dockerfile): removes a deadfoundflag. The return status is unchanged on every path.docs/runbook/add-an-adapter.mdpointed at a comment that no longer exists; it now namesrestore_pnpm_workspace.CONTRIBUTING.mddescribed the old lint gate; it now describes shellcheck + shfmt over every tracked shell file..env.examplelog comment said the opposite of what the setting does; fixed.# shellcheck source=directives name the real shared file.How it was verified
mise run lintpasses (shellcheck + shfmt).mise run test-runnerpasses, 266/266.tests/pnpm.batsfails with the guard reverted and passes with it restored.git diff -won the touched.batsfiles shows comment lines only.Checklist
mise run lintpassesmise run test-runnerpasses