refactor(tests): trim test comments and fix the ghcr login flake - #28
Merged
Merged
Conversation
added 2 commits
September 16, 2026 22:27
Tighten tests/*.bats and tests/helpers/setup.bash comments to a single WHY point each, dropping step narration, dates and incident counts while keeping the regression each assertion pins. Brings setup.bash's helper functions into the full [[ ]]/local/printf rule set. No test name or assertion changed.
stub3/docker never reads stdin, so printf token | docker login --password-stdin can die of SIGPIPE under pipefail, failing "start_stack logs in to ghcr only when a token is set" at random. Draining stdin on login keeps the stub's logging intact while removing the race.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
PR 4 of 5 (spec:
docs/superpowers/specs/2026-09-16-clean-shell-and-comments-design.md). Covers the shell undertests/.tests/helpers/setup.bash: follows the full bash rules ([[ ]],(( )),printf).@testbodies keep bats'[ ]idiom.8e59bff): intests/install.bats, thestub3/dockerstub now drains stdin onlogin.printffeedingdocker login --password-stdinincommon/install.shcould die of SIGPIPE underpipefail.No test names, assertions or fixture bytes changed.
How it was verified
mise run lintexits 0.mise run test-runnerpasses 265/265.Checklist
mise run lintpassesmise run test-runnerpasses